From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: dsa: b53: Fix build with B53_SRAB enabled and not B53_SERDES Date: Fri, 07 Sep 2018 23:12:30 -0700 (PDT) Message-ID: <20180907.231230.1214885710557159162.davem@davemloft.net> References: <20180906184245.31442-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, linux-kernel@vger.kernel.org To: f.fainelli@gmail.com Return-path: In-Reply-To: <20180906184245.31442-1-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Florian Fainelli Date: Thu, 6 Sep 2018 11:42:45 -0700 > In case B53_SRAB is enabled, but not B53_SERDES, we can get the > following linking error: > > ERROR: "b53_serdes_init" [drivers/net/dsa/b53/b53_srab.ko] undefined! > > We also need to ifdef the body of b53_srab_serdes_map_lane() since it > would not be used when B53_SERDES is disabled and that would produce a > warning. > > Fixes: 0e01491de646 ("net: dsa: b53: Add SerDes support") > Reported-by: kbuild test robot > Signed-off-by: Florian Fainelli Applied.