From mboxrd@z Thu Jan 1 00:00:00 1970 From: jun qian Subject: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet Date: Fri, 7 Sep 2018 09:21:17 -0700 Message-ID: <20180907162117.47361-1-hangdianqj@163.com> Cc: oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jun qian To: Jakub Kicinski , Dirk van der Merwe , Daniel Borkmann , Quentin Monnet Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org As you are already in a tasklet, it is unnecessary to call spin_lock_bh. Signed-off-by: jun qian --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c index a8b9fbab5f73..084c983ec3c2 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c @@ -2075,10 +2075,10 @@ static void nfp_ctrl_poll(unsigned long arg) { struct nfp_net_r_vector *r_vec = (void *)arg; - spin_lock_bh(&r_vec->lock); + spin_lock(&r_vec->lock); nfp_net_tx_complete(r_vec->tx_ring, 0); __nfp_ctrl_tx_queued(r_vec); - spin_unlock_bh(&r_vec->lock); + spin_unlock(&r_vec->lock); nfp_ctrl_rx(r_vec); -- 2.17.1