From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet Date: Fri, 7 Sep 2018 18:33:31 +0200 Message-ID: <20180907183331.7ed99ae3@cakuba> References: <20180907162117.47361-1-hangdianqj@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Dirk van der Merwe , Daniel Borkmann , Quentin Monnet , oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: jun qian Return-path: In-Reply-To: <20180907162117.47361-1-hangdianqj@163.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, 7 Sep 2018 09:21:17 -0700, jun qian wrote: > As you are already in a tasklet, it is unnecessary to call spin_lock_bh. > > Signed-off-by: jun qian We had more of those at some point, I wonder if you(r tool) can find them :) Acked-by: Jakub Kicinski