* [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet
@ 2018-09-07 16:21 jun qian
2018-09-07 16:33 ` Jakub Kicinski
2018-09-07 16:36 ` Jakub Kicinski
0 siblings, 2 replies; 4+ messages in thread
From: jun qian @ 2018-09-07 16:21 UTC (permalink / raw)
To: Jakub Kicinski, Dirk van der Merwe, Daniel Borkmann,
Quentin Monnet
Cc: oss-drivers, netdev, linux-kernel, jun qian
As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
Signed-off-by: jun qian <hangdianqj@163.com>
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index a8b9fbab5f73..084c983ec3c2 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -2075,10 +2075,10 @@ static void nfp_ctrl_poll(unsigned long arg)
{
struct nfp_net_r_vector *r_vec = (void *)arg;
- spin_lock_bh(&r_vec->lock);
+ spin_lock(&r_vec->lock);
nfp_net_tx_complete(r_vec->tx_ring, 0);
__nfp_ctrl_tx_queued(r_vec);
- spin_unlock_bh(&r_vec->lock);
+ spin_unlock(&r_vec->lock);
nfp_ctrl_rx(r_vec);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet
2018-09-07 16:21 [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet jun qian
@ 2018-09-07 16:33 ` Jakub Kicinski
2018-09-07 16:36 ` Jakub Kicinski
1 sibling, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2018-09-07 16:33 UTC (permalink / raw)
To: jun qian
Cc: Dirk van der Merwe, Daniel Borkmann, Quentin Monnet, oss-drivers,
netdev, linux-kernel
On Fri, 7 Sep 2018 09:21:17 -0700, jun qian wrote:
> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>
> Signed-off-by: jun qian <hangdianqj@163.com>
We had more of those at some point, I wonder if you(r tool) can find
them :)
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet
2018-09-07 16:21 [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet jun qian
2018-09-07 16:33 ` Jakub Kicinski
@ 2018-09-07 16:36 ` Jakub Kicinski
2018-09-07 17:35 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2018-09-07 16:36 UTC (permalink / raw)
To: jun qian
Cc: Dirk van der Merwe, Daniel Borkmann, Quentin Monnet, oss-drivers,
netdev, linux-kernel
On Fri, 7 Sep 2018 09:21:17 -0700, jun qian wrote:
> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>
> Signed-off-by: jun qian <hangdianqj@163.com>
FWIW you should put spaces after the colons. It's generally a good
practice to look at the prefix previous authors used for a given piece
of code with
git log -- $file_path
This would be a better subject:
nfp: replace spin_lock_bh with spin_lock in tasklet callback
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet
2018-09-07 16:36 ` Jakub Kicinski
@ 2018-09-07 17:35 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-09-07 17:35 UTC (permalink / raw)
To: jakub.kicinski
Cc: hangdianqj, dirk.vandermerwe, daniel, quentin.monnet, oss-drivers,
netdev, linux-kernel
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Fri, 7 Sep 2018 18:36:36 +0200
> On Fri, 7 Sep 2018 09:21:17 -0700, jun qian wrote:
>> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>>
>> Signed-off-by: jun qian <hangdianqj@163.com>
>
> FWIW you should put spaces after the colons. It's generally a good
> practice to look at the prefix previous authors used for a given piece
> of code with
>
> git log -- $file_path
>
> This would be a better subject:
>
> nfp: replace spin_lock_bh with spin_lock in tasklet callback
Yes, please fix your subject styling.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-07 17:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-07 16:21 [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet jun qian
2018-09-07 16:33 ` Jakub Kicinski
2018-09-07 16:36 ` Jakub Kicinski
2018-09-07 17:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).