From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: sched: act_skbedit: remove dependency on rtnl lock Date: Sat, 08 Sep 2018 10:18:00 -0700 (PDT) Message-ID: <20180908.101800.614337846370672885.davem@davemloft.net> References: <1535958435-6861-1-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us To: vladbu@mellanox.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:34860 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726765AbeIHWEc (ORCPT ); Sat, 8 Sep 2018 18:04:32 -0400 In-Reply-To: <1535958435-6861-1-git-send-email-vladbu@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Vlad Buslov Date: Mon, 3 Sep 2018 10:07:15 +0300 > According to the new locking rule, we have to take tcf_lock for both > ->init() and ->dump(), as RTNL will be removed. > > Use tcf lock to protect skbedit action struct private data from concurrent > modification in init and dump. Use rcu swap operation to reassign params > pointer under protection of tcf lock. (old params value is not used by > init, so there is no need of standalone rcu dereference step) > > Remove rtnl lock assertion that is no longer required. > > Signed-off-by: Vlad Buslov Applied.