[PATCH net-next] net: stmmac: Enable TC Ops for GMAC >= 4

[PATCH net-next] net: stmmac: Enable TC Ops for GMAC >= 4

[Jose Abreu]

GMAC >= 4 also supports CBS. Lets enable the TC Ops for these versions.

Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
---
 drivers/net/ethernet/stmicro/stmmac/hwif.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c
index d9a34a4d08b3..81b966a8261b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/hwif.c
+++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c
@@ -133,7 +133,7 @@ static const struct stmmac_hwif_entry {
 		.mac = &dwmac4_ops,
 		.hwtimestamp = &stmmac_ptp,
 		.mode = NULL,
-		.tc = NULL,
+		.tc = &dwmac510_tc_ops,
 		.setup = dwmac4_setup,
 		.quirks = stmmac_dwmac4_quirks,
 	}, {
@@ -150,7 +150,7 @@ static const struct stmmac_hwif_entry {
 		.mac = &dwmac410_ops,
 		.hwtimestamp = &stmmac_ptp,
 		.mode = &dwmac4_ring_mode_ops,
-		.tc = NULL,
+		.tc = &dwmac510_tc_ops,
 		.setup = dwmac4_setup,
 		.quirks = NULL,
 	}, {
@@ -167,7 +167,7 @@ static const struct stmmac_hwif_entry {
 		.mac = &dwmac410_ops,
 		.hwtimestamp = &stmmac_ptp,
 		.mode = &dwmac4_ring_mode_ops,
-		.tc = NULL,
+		.tc = &dwmac510_tc_ops,
 		.setup = dwmac4_setup,
 		.quirks = NULL,
 	}, {
-- 
2.7.4

Re: [PATCH net-next] net: stmmac: Enable TC Ops for GMAC >= 4

[David Miller]

From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Thu,  6 Sep 2018 13:29:30 +0100

> GMAC >= 4 also supports CBS. Lets enable the TC Ops for these versions.
> 
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>

Applied, thanks.

Please work to fix the performance regressions et al. that are still
unresolved in the driver.

This stmmac MAC is in such a varied number of chipsets that you
must be so extremely careful with every change you make to this
driver and I know that you cannot test a large portion of the
chips effected by your changes as you've stated as such in the
past.

Thank you.