From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net V2] ip: frags: fix crash in ip_do_fragment()
Date: Sun, 09 Sep 2018 14:51:33 -0700 (PDT)
Message-ID: <20180909.145133.589038459266292694.davem@davemloft.net>
References: <CANn89i+pBEuH-dg=f+3rxiheQyjJfg2=SqgoRmB4S7VEaVgeow@mail.gmail.com>
        <CAMArcTWjDRy-LpEKXzv4Zs-MiMGC25SkzCmNkB5Ks35_MWhoKQ@mail.gmail.com>
        <CANn89iKXTr+zy7ms5v7RNaz0BvQ1DMt+A7OfyPkypJZ9BvzeDg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: ap420073@gmail.com, posk@google.com, netdev@vger.kernel.org,
        pablo@netfilter.org, fw@strlen.de
To: edumazet@google.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:52842 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726665AbeIJCqB (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 9 Sep 2018 22:46:01 -0400
In-Reply-To: <CANn89iKXTr+zy7ms5v7RNaz0BvQ1DMt+A7OfyPkypJZ9BvzeDg@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Eric Dumazet <edumazet@google.com>
Date: Sun, 9 Sep 2018 13:51:21 -0700

>> Hi Eric,
>> Thank you for review!
>>
>> I think netfilter side ipv6 code change is needed
>> because netfilter ipv6 defrag routine also set fp->ip_defrag_offset value
>> so that fp->sk will not be NULL.
>> And I think these crash in ip_do_fragment() and ip6_fragment() are
>> actually same bug.
>>
> 
> Right you are, thanks.
> 
> Reviewed-by: Eric Dumazet <edumazet@google.com>

Applied, thanks everyone.