From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: ganeshgr@chelsio.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] cxgb4: remove redundant assignment to vlan_cmd.dropnovlan_fm
Date: Mon, 10 Sep 2018 10:01:34 -0700 (PDT) [thread overview]
Message-ID: <20180910.100134.1463498001968586861.davem@davemloft.net> (raw)
In-Reply-To: <20180910121722.15524-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Mon, 10 Sep 2018 13:17:22 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> A recent commit updated vlan_cmd.dropnovlan_fm but failed to remove
> the older assignment. Fix this by removing the former redundant
> assignment.
>
> Detected by CoverityScan, CID#1473290 ("Unused value")
>
> Fixes: a89cdd8e7c74 ("cxgb4: impose mandatory VLAN usage when non-zero TAG ID")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
prev parent reply other threads:[~2018-09-10 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 12:17 [PATCH][next] cxgb4: remove redundant assignment to vlan_cmd.dropnovlan_fm Colin King
2018-09-10 17:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910.100134.1463498001968586861.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=ganeshgr@chelsio.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox