From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tobias Hommel <netdev-list@genoetigt.de>
Subject: Re: kernels > v4.12 oops/crash with ipsec-traffic: bisected to
 b838d5e1c5b6e57b10ec8af2268824041e3ea911: ipv4: mark DST_NOGC and remove the
 operation of dst_free()
Date: Mon, 10 Sep 2018 11:06:22 +0200
Message-ID: <20180910090622.avunyp4agk4ueara@arbeitstier>
References: <3482600.6PjfSIYROA@stwm.de>
 <20180831065024.GG23674@gauss3.secunet.de>
 <1591446.aUMgYVGcZN@stwm.de>
 <1619354.H6dCVflbiu@stwm.de>
 <20180910063739.GX23674@gauss3.secunet.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Wolfgang Walter <linux@stwm.de>, netdev@vger.kernel.org,
        Wei Wang <weiwan@google.com>,
        Eric Dumazet <edumazet@google.com>
To: Steffen Klassert <steffen.klassert@secunet.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.brieftier.de ([88.99.33.249]:60490 "EHLO mail.brieftier.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727261AbeIJN70 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 10 Sep 2018 09:59:26 -0400
Content-Disposition: inline
In-Reply-To: <20180910063739.GX23674@gauss3.secunet.de>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Sep 10, 2018 at 08:37:39AM +0200, Steffen Klassert wrote:
...
> The other thing I wonder about is why Tobias bisected this to
> 
> commit b838d5e1c5b6e57b10ec8af2268824041e3ea911
> ipv4: mark DST_NOGC and remove the operation of dst_free()
> 
> from 'Jun 17 2017' and not to
> 
> commit 222d7dbd258dad4cd5241c43ef818141fad5a87a
> net: prevent dst uses after free
> 
> from 'Sep 21 2017'.
> 
> Maybe Tobias has seen two bugs. Before
> ("net: prevent dst uses after free"), it was the
> use after free, and after this fix it was a NULL
> pointer derference of skb->dst.
> 
Uhm, yeah, I checked back, we actually had different bugs. My mistake, sorry
for the confusion.