From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Benc Subject: Re: [PATCH] net: ipv4: Use BUG_ON directly instead of a if condition followed by BUG Date: Mon, 10 Sep 2018 17:39:57 +0200 Message-ID: <20180910173957.5f3728e6@redhat.com> References: <1536590282-23899-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: , , , , , To: zhong jiang Return-path: In-Reply-To: <1536590282-23899-1-git-send-email-zhongjiang@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 10 Sep 2018 22:38:02 +0800, zhong jiang wrote: > + BUG(skb_copy_bits(skb, ptr, &tmp, 1)); I doubt this builds. Jiri