From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next 1/8] devlink: Add generic parameter hw_tc_offload Date: Tue, 11 Sep 2018 11:51:30 +0200 Message-ID: <20180911095130.GC25110@nanopsycho> References: <1536655505-14387-1-git-send-email-vasundhara-v.volam@broadcom.com> <1536655505-14387-2-git-send-email-vasundhara-v.volam@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, michael.chan@broadcom.com, netdev@vger.kernel.org To: Vasundhara Volam Return-path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:38673 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726554AbeIKOyU (ORCPT ); Tue, 11 Sep 2018 10:54:20 -0400 Received: by mail-wr1-f67.google.com with SMTP id w11-v6so25190900wrc.5 for ; Tue, 11 Sep 2018 02:55:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1536655505-14387-2-git-send-email-vasundhara-v.volam@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: Tue, Sep 11, 2018 at 10:44:58AM CEST, vasundhara-v.volam@broadcom.com wrote: >hw_tc_offload - Enable/Disable TC flower offload in the device. > >Signed-off-by: Vasundhara Volam >--- > include/net/devlink.h | 4 ++++ > net/core/devlink.c | 5 +++++ > 2 files changed, 9 insertions(+) > >diff --git a/include/net/devlink.h b/include/net/devlink.h >index b9b89d6..a0e9ce9 100644 >--- a/include/net/devlink.h >+++ b/include/net/devlink.h >@@ -362,6 +362,7 @@ enum devlink_param_generic_id { > DEVLINK_PARAM_GENERIC_ID_MAX_MACS, > DEVLINK_PARAM_GENERIC_ID_ENABLE_SRIOV, > DEVLINK_PARAM_GENERIC_ID_REGION_SNAPSHOT, >+ DEVLINK_PARAM_GENERIC_ID_HW_TC_OFFLOAD, Could you please describe why do you need this here and why the tc_offload flag in ethtool is not enough. How do you imagine the user should use them together?