From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Cc: davem@davemloft.net, michael.chan@broadcom.com,
netdev@vger.kernel.org,
Alexander Duyck <alexander.duyck@gmail.com>
Subject: Re: [PATCH net-next 0/8] bnxt_en: devlink param updates
Date: Tue, 11 Sep 2018 13:33:51 +0200 [thread overview]
Message-ID: <20180911133215.5798ed2a@cakuba> (raw)
In-Reply-To: <1536655505-14387-1-git-send-email-vasundhara-v.volam@broadcom.com>
On Tue, 11 Sep 2018 14:14:57 +0530, Vasundhara Volam wrote:
> This patchset adds support for 4 generic and 1 driver-specific devlink
> parameters.
>
> Also, this patchset adds support to return proper error code if
> HWRM_NVM_GET/SET_VARIABLE commands return error code
> HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED.
>
> Vasundhara Volam (8):
> devlink: Add generic parameter hw_tc_offload
Much like Jiri, I can't help but wonder why do you need this?
> devlink: Add generic parameter ignore_ari
> devlink: Add generic parameter msix_vec_per_pf_max
> devlink: Add generic parameter msix_vec_per_pf_min
IMHO more structured API would be preferable if possible. The string
keys won't scale if you want to set the parameters per PF, and
creating more structured API for PCIe which is a relatively slow
moving HW spec seems tractable.
Not to mention the question Alex posed before about where this knobs
should actually live. I'm personally fine with devlink.
> bnxt_en: Use hw_tc_offload and ignore_ari devlink parameters
> bnxt_en: return proper error when FW returns
> HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED
> bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink
> params.
> bnxt_en: Add a driver specific devlink parameter.
The details about the device specific devlink parameter are very much
lacking. Why does the patch subject not mention any specifics? What's
GRE in the first place?
You really need to provide more details and docs for all these
parameters.
next prev parent reply other threads:[~2018-09-11 16:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 8:44 [PATCH net-next 0/8] bnxt_en: devlink param updates Vasundhara Volam
2018-09-11 8:44 ` [PATCH net-next 1/8] devlink: Add generic parameter hw_tc_offload Vasundhara Volam
2018-09-11 9:51 ` Jiri Pirko
2018-09-12 6:17 ` Vasundhara Volam
2018-09-12 6:34 ` Jakub Kicinski
2018-09-13 9:08 ` Jiri Pirko
2018-09-11 8:44 ` [PATCH net-next 2/8] devlink: Add generic parameter ignore_ari Vasundhara Volam
2018-09-11 8:45 ` [PATCH net-next 3/8] devlink: Add generic parameter msix_vec_per_pf_max Vasundhara Volam
2018-09-11 8:45 ` [PATCH net-next 4/8] devlink: Add generic parameter msix_vec_per_pf_min Vasundhara Volam
2018-09-11 8:45 ` [PATCH net-next 5/8] bnxt_en: Use hw_tc_offload and ignore_ari devlink parameters Vasundhara Volam
2018-09-14 8:58 ` kbuild test robot
2018-09-11 8:45 ` [PATCH net-next 6/8] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED Vasundhara Volam
2018-09-11 8:45 ` [PATCH net-next 7/8] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params Vasundhara Volam
2018-09-11 8:45 ` [PATCH net-next 8/8] bnxt_en: Add a driver specific devlink parameter Vasundhara Volam
2018-09-11 11:33 ` Jakub Kicinski [this message]
2018-09-11 11:51 ` [PATCH net-next 0/8] bnxt_en: devlink param updates Jiri Pirko
2018-09-12 6:40 ` Vasundhara Volam
2018-09-12 6:39 ` Vasundhara Volam
2018-09-12 9:50 ` Jakub Kicinski
2018-09-14 4:17 ` Vasundhara Volam
2018-09-14 10:01 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911133215.5798ed2a@cakuba \
--to=jakub.kicinski@netronome.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).