From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net] tipc: check return value of __tipc_dump_start() Date: Wed, 12 Sep 2018 13:15:51 -0700 (PDT) Message-ID: <20180912.131551.1887335291171363201.davem@davemloft.net> References: <20180911221217.23392-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, jon.maloy@ericsson.com, ying.xue@windriver.com To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:38374 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726750AbeIMBWB (ORCPT ); Wed, 12 Sep 2018 21:22:01 -0400 In-Reply-To: <20180911221217.23392-1-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Tue, 11 Sep 2018 15:12:17 -0700 > When __tipc_dump_start() fails with running out of memory, > we have no reason to continue, especially we should avoid > calling tipc_dump_done(). > > Fixes: 8f5c5fcf3533 ("tipc: call start and done ops directly in __tipc_nl_compat_dumpit()") > Reported-and-tested-by: syzbot+3f8324abccfbf8c74a9f@syzkaller.appspotmail.com > Cc: Jon Maloy > Cc: Ying Xue > Signed-off-by: Cong Wang Applied, thanks Cong.