From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3 net-next 00/12] Preparing for phylib limkmodes Date: Wed, 12 Sep 2018 20:24:39 -0700 (PDT) Message-ID: <20180912.202439.1267809657751757165.davem@davemloft.net> References: <1536709999-13420-1-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, f.fainelli@gmail.com To: andrew@lunn.ch Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:42298 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbeIMIcO (ORCPT ); Thu, 13 Sep 2018 04:32:14 -0400 In-Reply-To: <1536709999-13420-1-git-send-email-andrew@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: From: Andrew Lunn Date: Wed, 12 Sep 2018 01:53:07 +0200 > phylib currently makes us of a u32 bitmap for advertising, supported, > and link partner capabilities. For a long time, this has been > sufficient, for devices up to 1Gbps. With more MAC/PHY combinations > now supporting speeds greater than 1Gbps, we have run out of > bits. There is the need to replace this u32 with an > __ETHTOOL_DECLARE_LINK_MODE_MASK, which makes use of linux's generic > bitmaps. > > This patchset does some of the work preparing for this change. A few > cleanups are applied to PHY drivers. Some MAC drivers directly access > members of phydev which are going to change type. These patches adds > some helpers and swaps MAC drivers to use them, mostly dealing with > Pause configuration. > > v3: > Reviewed-by: Florian Fainelli > Add missing at in commit message > Change Subject of patch 5 > Fix return in from phy_set_asym_pause > Fix kerneldoc in phy_set_pause > > v2: > Fixup bad indentation in tg3.c > Rename phy_support_pause() to phy_support_sym_pause() > Also trigger autoneg if the advertising settings have changed. > Rename phy_set_pause() to phy_set_sym_pause() > Use the bcm63xx_enet.c logic, not fec_main.c for validating pause Series applied, thanks Andrew.