From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [net-next, PATCH 2/2, v2] net: socionext: add XDP support
Date: Wed, 12 Sep 2018 12:29:15 +0300
Message-ID: <20180912092915.GA31978@apalos>
References: <1536742958-29887-1-git-send-email-ilias.apalodimas@linaro.org>
 <1536742958-29887-3-git-send-email-ilias.apalodimas@linaro.org>
 <20180912112524.34250d1c@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, jaswinder.singh@linaro.org,
        ard.biesheuvel@linaro.org, masami.hiramatsu@linaro.org,
        arnd@arndb.de, mykyta.iziumtsev@linaro.org, bjorn.topel@intel.com,
        magnus.karlsson@intel.com, daniel@iogearbox.net, ast@kernel.org
To: Jesper Dangaard Brouer <brouer@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f68.google.com ([209.85.221.68]:34646 "EHLO
        mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727616AbeILOdC (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 12 Sep 2018 10:33:02 -0400
Received: by mail-wr1-f68.google.com with SMTP id g33-v6so1263501wrd.1
        for <netdev@vger.kernel.org>; Wed, 12 Sep 2018 02:29:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180912112524.34250d1c@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Sep 12, 2018 at 11:25:24AM +0200, Jesper Dangaard Brouer wrote:
> On Wed, 12 Sep 2018 12:02:38 +0300
> Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote:
> 
> >  static const struct net_device_ops netsec_netdev_ops = {
> >  	.ndo_init		= netsec_netdev_init,
> >  	.ndo_uninit		= netsec_netdev_uninit,
> > @@ -1430,6 +1627,7 @@ static const struct net_device_ops netsec_netdev_ops = {
> >  	.ndo_set_mac_address    = eth_mac_addr,
> >  	.ndo_validate_addr	= eth_validate_addr,
> >  	.ndo_do_ioctl		= netsec_netdev_ioctl,
> > +	.ndo_bpf		= netsec_xdp,
> >  };
> >  
> 
> You have not implemented ndo_xdp_xmit.
> 
> Thus, you have "only" implemented the RX side of XDP_REDIRECT.  Which
> allows you to do, cpumap and AF_XDP redirects, but not allowing other
> drivers to XDP send out this device.
Correct, that was the planning, is ndo_xdp_xmit() needed for the patch or
is the patch message just misleading and i should change that ?

Thanks
/Ilias