From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [net-next, PATCH 2/2, v2] net: socionext: add XDP support Date: Wed, 12 Sep 2018 11:14:57 +0200 Message-ID: <20180912111457.0121d9f3@redhat.com> References: <1536742958-29887-1-git-send-email-ilias.apalodimas@linaro.org> <1536742958-29887-3-git-send-email-ilias.apalodimas@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jaswinder.singh@linaro.org, ard.biesheuvel@linaro.org, masami.hiramatsu@linaro.org, arnd@arndb.de, mykyta.iziumtsev@linaro.org, bjorn.topel@intel.com, magnus.karlsson@intel.com, daniel@iogearbox.net, ast@kernel.org, brouer@redhat.com To: Ilias Apalodimas Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36458 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727391AbeILOSn (ORCPT ); Wed, 12 Sep 2018 10:18:43 -0400 In-Reply-To: <1536742958-29887-3-git-send-email-ilias.apalodimas@linaro.org> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 12 Sep 2018 12:02:38 +0300 Ilias Apalodimas wrote: > @@ -1003,20 +1076,29 @@ static int netsec_setup_rx_dring(struct netsec_priv *priv) > u16 len; > > buf = netsec_alloc_rx_data(priv, &dma_handle, &len); > - if (!buf) { > - netsec_uninit_pkt_dring(priv, NETSEC_RING_RX); > + if (!buf) > goto err_out; > - } > desc->dma_addr = dma_handle; > desc->addr = buf; > desc->len = len; > } > > netsec_rx_fill(priv, 0, DESC_NUM); > + err = xdp_rxq_info_reg(&dring->xdp_rxq, priv->ndev, 0); Do you only have 1 RX queue? (last arg to xdp_rxq_info_reg is 0), > + if (err) > + goto err_out; > + > + err = xdp_rxq_info_reg_mem_model(&dring->xdp_rxq, MEM_TYPE_PAGE_SHARED, > + NULL); > + if (err) { > + xdp_rxq_info_unreg(&dring->xdp_rxq); > + goto err_out; > + } > > return 0; > -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer