From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [net-next, PATCH 2/2, v2] net: socionext: add XDP support Date: Wed, 12 Sep 2018 11:25:24 +0200 Message-ID: <20180912112524.34250d1c@redhat.com> References: <1536742958-29887-1-git-send-email-ilias.apalodimas@linaro.org> <1536742958-29887-3-git-send-email-ilias.apalodimas@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jaswinder.singh@linaro.org, ard.biesheuvel@linaro.org, masami.hiramatsu@linaro.org, arnd@arndb.de, mykyta.iziumtsev@linaro.org, bjorn.topel@intel.com, magnus.karlsson@intel.com, daniel@iogearbox.net, ast@kernel.org, brouer@redhat.com To: Ilias Apalodimas Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53482 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727153AbeILO3M (ORCPT ); Wed, 12 Sep 2018 10:29:12 -0400 In-Reply-To: <1536742958-29887-3-git-send-email-ilias.apalodimas@linaro.org> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 12 Sep 2018 12:02:38 +0300 Ilias Apalodimas wrote: > static const struct net_device_ops netsec_netdev_ops = { > .ndo_init = netsec_netdev_init, > .ndo_uninit = netsec_netdev_uninit, > @@ -1430,6 +1627,7 @@ static const struct net_device_ops netsec_netdev_ops = { > .ndo_set_mac_address = eth_mac_addr, > .ndo_validate_addr = eth_validate_addr, > .ndo_do_ioctl = netsec_netdev_ioctl, > + .ndo_bpf = netsec_xdp, > }; > You have not implemented ndo_xdp_xmit. Thus, you have "only" implemented the RX side of XDP_REDIRECT. Which allows you to do, cpumap and AF_XDP redirects, but not allowing other drivers to XDP send out this device. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer