* [PATCH iproute2] q_cake: Add printing of no-split-gso option
@ 2018-09-11 22:32 Toke Høiland-Jørgensen
2018-09-12 20:07 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2018-09-11 22:32 UTC (permalink / raw)
To: netdev; +Cc: Toke Høiland-Jørgensen
When the GSO splitting was turned into dual split-gso/no-split-gso options,
the printing of the latter was left out. Add that, so output is consistent
with the options passed.
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
---
tc/q_cake.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tc/q_cake.c b/tc/q_cake.c
index 50de46a7..077bf84f 100644
--- a/tc/q_cake.c
+++ b/tc/q_cake.c
@@ -524,6 +524,8 @@ static int cake_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
if (split_gso)
print_string(PRINT_FP, NULL, "split-gso ", NULL);
+ else
+ print_string(PRINT_FP, NULL, "no-split-gso ", NULL);
print_bool(PRINT_JSON, "split_gso", NULL, split_gso);
if (interval)
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] q_cake: Add printing of no-split-gso option
2018-09-11 22:32 [PATCH iproute2] q_cake: Add printing of no-split-gso option Toke Høiland-Jørgensen
@ 2018-09-12 20:07 ` Stephen Hemminger
2018-09-14 13:40 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2018-09-12 20:07 UTC (permalink / raw)
To: Toke Høiland-Jørgensen; +Cc: netdev
On Wed, 12 Sep 2018 00:32:16 +0200
Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> When the GSO splitting was turned into dual split-gso/no-split-gso options,
> the printing of the latter was left out. Add that, so output is consistent
> with the options passed.
>
> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
Applied. I noticed that nat/nonat and wash/nowash have similar missing output.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] q_cake: Add printing of no-split-gso option
2018-09-12 20:07 ` Stephen Hemminger
@ 2018-09-14 13:40 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2018-09-14 13:40 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
Stephen Hemminger <stephen@networkplumber.org> writes:
> On Wed, 12 Sep 2018 00:32:16 +0200
> Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>
>> When the GSO splitting was turned into dual split-gso/no-split-gso options,
>> the printing of the latter was left out. Add that, so output is consistent
>> with the options passed.
>>
>> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
>
> Applied. I noticed that nat/nonat and wash/nowash have similar missing
> output.
Thanks! And yeah, you're right; I'll send another patch :)
-Toke
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-14 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-11 22:32 [PATCH iproute2] q_cake: Add printing of no-split-gso option Toke Høiland-Jørgensen
2018-09-12 20:07 ` Stephen Hemminger
2018-09-14 13:40 ` Toke Høiland-Jørgensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).