From: Andrew Lunn <andrew@lunn.ch>
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: Add MV88E6352 DT compatible
Date: Wed, 12 Sep 2018 15:32:22 +0200 [thread overview]
Message-ID: <20180912133222.GC24595@lunn.ch> (raw)
In-Reply-To: <2efc9a68-fc8c-2a85-14f8-bc2c72d9957f@denx.de>
> But the DT should correctly describe the hardware, if it doesn't, it's
> just broken.
It is more subtle than that. It can be broken, yet work, because it
contains information which we don't use. I really expect there will be
cut/paste errors, meaning the more specific compatible is sometimes
wrong. But since at the moment we don't use it, such a broken DT blob
will work. Until the day we need to make use of the more specific
compatible because there really is broken silicon. At that point, we
introduce a regression. All the devices with broke, yet up until now
working DT blobs, stop working. Are you really going to argue they
where always broken, so we don't care we introduced a regression?
Anyway, this is just rehasing an old discussion. Please go read the
archive. See if you have anything new to add which was not discussed
before.
Andrew
next prev parent reply other threads:[~2018-09-12 18:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 22:15 [PATCH] net: dsa: mv88e6xxx: Add MV88E6352 DT compatible Marek Vasut
2018-09-11 23:12 ` Andrew Lunn
2018-09-11 23:17 ` Marek Vasut
2018-09-11 23:32 ` Andrew Lunn
2018-09-11 23:52 ` Brandon Streiff
2018-09-12 0:04 ` Marek Vasut
2018-09-12 0:46 ` Andrew Lunn
2018-09-12 8:38 ` Marek Vasut
2018-09-12 12:47 ` Andrew Lunn
2018-09-12 13:10 ` Marek Vasut
2018-09-12 13:32 ` Andrew Lunn [this message]
2018-09-12 13:35 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912133222.GC24595@lunn.ch \
--to=andrew@lunn.ch \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).