From: David Miller <davem@davemloft.net>
To: kai.heng.feng@canonical.com
Cc: nic_swsd@realtek.com, hkallweit1@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] r8169: Align ASPM/CLKREQ setting function with vendor driver
Date: Thu, 13 Sep 2018 10:48:13 -0700 (PDT) [thread overview]
Message-ID: <20180913.104813.1180256346366643481.davem@davemloft.net> (raw)
In-Reply-To: <20180912065821.7198-1-kai.heng.feng@canonical.com>
From: Kai-Heng Feng <kai.heng.feng@canonical.com>
Date: Wed, 12 Sep 2018 14:58:20 +0800
> There's a small delay after setting ASPM in vendor drivers, r8101 and
> r8168.
> In addition, those drivers enable ASPM before ClkReq, also change that
> to align with vendor driver.
>
> I haven't seen anything bad becasue of this, but I think it's better to
> keep in sync with vendor driver.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
I want Heiner Kallweit to review these before I apply them.
Thanks.
next prev parent reply other threads:[~2018-09-13 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 6:58 [PATCH 1/2] r8169: Align ASPM/CLKREQ setting function with vendor driver Kai-Heng Feng
2018-09-12 6:58 ` [PATCH 2/2] r8169: enable ASPM on RTL8106E Kai-Heng Feng
2018-09-18 1:46 ` David Miller
2018-09-13 17:48 ` David Miller [this message]
2018-09-18 1:46 ` [PATCH 1/2] r8169: Align ASPM/CLKREQ setting function with vendor driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913.104813.1180256346366643481.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).