From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/2] r8169: Align ASPM/CLKREQ setting function with vendor driver Date: Thu, 13 Sep 2018 10:48:13 -0700 (PDT) Message-ID: <20180913.104813.1180256346366643481.davem@davemloft.net> References: <20180912065821.7198-1-kai.heng.feng@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nic_swsd@realtek.com, hkallweit1@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: kai.heng.feng@canonical.com Return-path: In-Reply-To: <20180912065821.7198-1-kai.heng.feng@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Kai-Heng Feng Date: Wed, 12 Sep 2018 14:58:20 +0800 > There's a small delay after setting ASPM in vendor drivers, r8101 and > r8168. > In addition, those drivers enable ASPM before ClkReq, also change that > to align with vendor driver. > > I haven't seen anything bad becasue of this, but I think it's better to > keep in sync with vendor driver. > > Signed-off-by: Kai-Heng Feng I want Heiner Kallweit to review these before I apply them. Thanks.