From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: rtnl_configure_link: fix dev flags changes arg to __dev_notify_flags Date: Thu, 13 Sep 2018 11:02:53 -0700 (PDT) Message-ID: <20180913.110253.1107152404318857888.davem@davemloft.net> References: <1536783708-21949-1-git-send-email-roopa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, stephen@networkplumber.org, liam.mcbirnie@boeing.com To: roopa@cumulusnetworks.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:51798 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727811AbeIMXN3 (ORCPT ); Thu, 13 Sep 2018 19:13:29 -0400 In-Reply-To: <1536783708-21949-1-git-send-email-roopa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Roopa Prabhu Date: Wed, 12 Sep 2018 13:21:48 -0700 > From: Roopa Prabhu > > This fix addresses https://bugzilla.kernel.org/show_bug.cgi?id=201071 > > Commit 5025f7f7d506 wrongly relied on __dev_change_flags to notify users of > dev flag changes in the case when dev->rtnl_link_state = RTNL_LINK_INITIALIZED. > Fix it by indicating flag changes explicitly to __dev_notify_flags. > > Fixes: 5025f7f7d506 ("rtnetlink: add rtnl_link_state check in rtnl_configure_link") > Reported-By: Liam mcbirnie > Signed-off-by: Roopa Prabhu Applied. > --- > Dave, if 5025f7f7d506 made it to stable, request you to pls queue this one up too. Thanks. I will, thanks.