From: David Miller <davem@davemloft.net>
To: keescook@chromium.org
Cc: netdev@vger.kernel.org, benh@kernel.crashing.org,
chunkeey@gmail.com, ivan@de.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/ibm/emac: Remove VLA usage
Date: Thu, 13 Sep 2018 16:53:39 -0700 (PDT) [thread overview]
Message-ID: <20180913.165339.1563703982938238294.davem@davemloft.net> (raw)
In-Reply-To: <20180913212356.GA37936@beast>
From: Kees Cook <keescook@chromium.org>
Date: Thu, 13 Sep 2018 14:23:56 -0700
> In the quest to remove all stack VLA usage from the kernel[1], this
> removes the VLA used for the emac xaht registers size. Since the size
> of registers can only ever be 4 or 8, as detected in emac_init_config(),
> the max can be hardcoded and a runtime test added for robustness.
>
> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Christian Lamparter <chunkeey@gmail.com>
> Cc: Ivan Mikhaylov <ivan@de.ibm.com>
> Cc: netdev@vger.kernel.org
> Co-developed-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Applied to net-next, thanks.
prev parent reply other threads:[~2018-09-13 23:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 21:23 [PATCH] net/ibm/emac: Remove VLA usage Kees Cook
2018-09-13 23:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913.165339.1563703982938238294.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=chunkeey@gmail.com \
--cc=ivan@de.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).