From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Tushar Dave <tushar.n.dave@oracle.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net,
santosh.shilimkar@oracle.com, jakub.kicinski@netronome.com,
quentin.monnet@netronome.com, jiong.wang@netronome.com,
sandipan@linux.vnet.ibm.com, john.fastabend@gmail.com,
kafai@fb.com, rdna@fb.com, yhs@fb.com, netdev@vger.kernel.org,
rds-devel@oss.oracle.com
Subject: Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER
Date: Wed, 12 Sep 2018 20:59:54 -0400 [thread overview]
Message-ID: <20180913005954.GA30305@oracle.com> (raw)
In-Reply-To: <74f959c3-27ef-a67c-6a54-599d84cde90b@oracle.com>
> On 09/11/2018 09:00 PM, Alexei Starovoitov wrote:
> >please no samples.
> >Add this as proper test to tools/testing/selftests/bpf
> >that reports PASS/FAIL and can be run automatically.
> >samples/bpf is effectively dead code.
Just a second.
You do realize that RDS is doing real networking, so it needs
RDMA capable hardware to test the rds_rdma paths? Also, when we
"talk to ourselves" we default to the rds_loop transport, so
we would even bypass the rds-tcp module.
I dont think this can be tested with some academic "test it
over lo0" exercise.. I suppose you can add example code in
sefltests for this, but asking for a "proper test" may be
a litte unrealistic here- a proper test needs proper hardware
in this case.
--Sowmini
next prev parent reply other threads:[~2018-09-13 6:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 19:37 [PATCH net-next 0/5] eBPF and struct scatterlist Tushar Dave
2018-09-11 19:38 ` [PATCH net-next 1/5] bpf: use __GFP_COMP while allocating page Tushar Dave
2018-09-12 16:21 ` Tushar Dave
2018-09-12 16:51 ` John Fastabend
2018-09-12 20:15 ` Tushar Dave
2018-09-11 19:38 ` [PATCH net-next 2/5] eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER Tushar Dave
2018-09-12 3:57 ` Alexei Starovoitov
2018-09-12 19:25 ` Tushar Dave
2018-09-11 19:38 ` [PATCH net-next 3/5] ebpf: Add sg_filter_run() Tushar Dave
2018-09-12 3:58 ` Alexei Starovoitov
2018-09-12 19:27 ` Tushar Dave
2018-09-11 19:38 ` [PATCH net-next 4/5] rds: invoke socket sg filter attached to rds socket Tushar Dave
2018-09-11 21:06 ` santosh.shilimkar
2018-09-11 19:38 ` [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER Tushar Dave
2018-09-12 4:00 ` Alexei Starovoitov
2018-09-12 19:32 ` Tushar Dave
2018-09-13 0:59 ` Sowmini Varadhan [this message]
2018-09-13 2:07 ` Alexei Starovoitov
2018-09-13 10:10 ` Sowmini Varadhan
2018-09-17 23:15 ` Alexei Starovoitov
2018-09-17 23:23 ` Sowmini Varadhan
2018-09-17 23:26 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913005954.GA30305@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiong.wang@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@netronome.com \
--cc=rdna@fb.com \
--cc=rds-devel@oss.oracle.com \
--cc=sandipan@linux.vnet.ibm.com \
--cc=santosh.shilimkar@oracle.com \
--cc=tushar.n.dave@oracle.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).