From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowmini Varadhan Subject: Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER Date: Wed, 12 Sep 2018 20:59:54 -0400 Message-ID: <20180913005954.GA30305@oracle.com> References: <1536694684-3200-1-git-send-email-tushar.n.dave@oracle.com> <1536694684-3200-6-git-send-email-tushar.n.dave@oracle.com> <20180912040038.oobnr4yfzoaajk6k@ast-mbp> <74f959c3-27ef-a67c-6a54-599d84cde90b@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexei Starovoitov , ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, santosh.shilimkar@oracle.com, jakub.kicinski@netronome.com, quentin.monnet@netronome.com, jiong.wang@netronome.com, sandipan@linux.vnet.ibm.com, john.fastabend@gmail.com, kafai@fb.com, rdna@fb.com, yhs@fb.com, netdev@vger.kernel.org, rds-devel@oss.oracle.com To: Tushar Dave Return-path: Received: from aserp2120.oracle.com ([141.146.126.78]:41458 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbeIMGHh (ORCPT ); Thu, 13 Sep 2018 02:07:37 -0400 Content-Disposition: inline In-Reply-To: <74f959c3-27ef-a67c-6a54-599d84cde90b@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: > On 09/11/2018 09:00 PM, Alexei Starovoitov wrote: > >please no samples. > >Add this as proper test to tools/testing/selftests/bpf > >that reports PASS/FAIL and can be run automatically. > >samples/bpf is effectively dead code. Just a second. You do realize that RDS is doing real networking, so it needs RDMA capable hardware to test the rds_rdma paths? Also, when we "talk to ourselves" we default to the rds_loop transport, so we would even bypass the rds-tcp module. I dont think this can be tested with some academic "test it over lo0" exercise.. I suppose you can add example code in sefltests for this, but asking for a "proper test" may be a litte unrealistic here- a proper test needs proper hardware in this case. --Sowmini