From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next 1/8] devlink: Add generic parameter hw_tc_offload Date: Thu, 13 Sep 2018 11:08:53 +0200 Message-ID: <20180913090853.GI25110@nanopsycho> References: <1536655505-14387-1-git-send-email-vasundhara-v.volam@broadcom.com> <1536655505-14387-2-git-send-email-vasundhara-v.volam@broadcom.com> <20180911095130.GC25110@nanopsycho> <20180912083422.004b21a0@cakuba> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Vasundhara Volam , David Miller , "michael.chan@broadcom.com" , Netdev To: Jakub Kicinski Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:33912 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726838AbeIMOVm (ORCPT ); Thu, 13 Sep 2018 10:21:42 -0400 Received: by mail-wm0-f67.google.com with SMTP id j25-v6so1114798wmc.1 for ; Thu, 13 Sep 2018 02:13:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180912083422.004b21a0@cakuba> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Sep 12, 2018 at 08:34:22AM CEST, jakub.kicinski@netronome.com wrote: >On Wed, 12 Sep 2018 11:47:59 +0530, Vasundhara Volam wrote: >> On Tue, Sep 11, 2018 at 3:25 PM Jiri Pirko wrote: >> > >> > Tue, Sep 11, 2018 at 10:44:58AM CEST, vasundhara-v.volam@broadcom.com wrote: >> > >hw_tc_offload - Enable/Disable TC flower offload in the device. >> > > >> > >Signed-off-by: Vasundhara Volam >> > >--- >> > > include/net/devlink.h | 4 ++++ >> > > net/core/devlink.c | 5 +++++ >> > > 2 files changed, 9 insertions(+) >> > > >> > >diff --git a/include/net/devlink.h b/include/net/devlink.h >> > >index b9b89d6..a0e9ce9 100644 >> > >--- a/include/net/devlink.h >> > >+++ b/include/net/devlink.h >> > >@@ -362,6 +362,7 @@ enum devlink_param_generic_id { >> > > DEVLINK_PARAM_GENERIC_ID_MAX_MACS, >> > > DEVLINK_PARAM_GENERIC_ID_ENABLE_SRIOV, >> > > DEVLINK_PARAM_GENERIC_ID_REGION_SNAPSHOT, >> > >+ DEVLINK_PARAM_GENERIC_ID_HW_TC_OFFLOAD, >> > >> > Could you please describe why do you need this here and why the >> > tc_offload flag in ethtool is not enough. How do you imagine the user >> > should use them together? >> Jiri, tc_offload flag in ethtool will modify feature in driver at >> runtime. But I am adding >> tc_offload param here to toggle this feature in NVM Config of our >> adapter, whose configuration >> mode is permanent and will be effective only with a reboot of the server. >> >> User has to turn on tc_offload feature in NVM config of the adapter and then >> enabling the tc_offload flag in ethtool will completely enable the >> feature in driver. > >Thanks for explaining, however, I don't think we have trouble >understanding *what* you are doing, but rather *why* you're doing it. Exactly. Why ethtool tc_offload flag is not enough?