From: Andrew Lunn <andrew@lunn.ch>
To: Wang Dongsheng <dongsheng.wang@hxt-semitech.com>
Cc: timur@kernel.org, davem@davemloft.net, yu.zheng@hxt-semitech.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] net: qcom/emac: add shared mdio bus support
Date: Thu, 13 Sep 2018 14:42:29 +0200 [thread overview]
Message-ID: <20180913124229.GD11702@lunn.ch> (raw)
In-Reply-To: <1536829493-10088-3-git-send-email-dongsheng.wang@hxt-semitech.com>
On Thu, Sep 13, 2018 at 05:04:53PM +0800, Wang Dongsheng wrote:
> Share the mii_bus for others MAC device because QDF2400 emac
> include MDIO, and the motherboard has more than one PHY connected
> to an MDIO bus.
>
> Tested: QDF2400 (ACPI), buildin/insmod/rmmod
>
> Signed-off-by: Wang Dongsheng <dongsheng.wang@hxt-semitech.com>
Hi Wang
This is a pretty big patch, and is hard to review. Could you try to
break it up into a number of smaller patches. You could for example
first refactor emacs_phy_config(), without making any functional
changes. Then add the sharing. Maybe do OF an ACPI in different
patches?
Thanks
Andrew
next prev parent reply other threads:[~2018-09-13 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 9:04 [PATCH 0/2] net: qcom/emac: add shared mdio bus support Wang Dongsheng
2018-09-13 9:04 ` [PATCH 2/2] " Wang Dongsheng
2018-09-13 12:42 ` Andrew Lunn [this message]
2018-09-13 15:03 ` Timur Tabi
2018-09-13 15:20 ` Wang, Dongsheng
2018-09-13 12:24 ` [PATCH 0/2] " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913124229.GD11702@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dongsheng.wang@hxt-semitech.com \
--cc=netdev@vger.kernel.org \
--cc=timur@kernel.org \
--cc=yu.zheng@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).