From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 2/2] net: qcom/emac: add shared mdio bus support
Date: Thu, 13 Sep 2018 14:42:29 +0200
Message-ID: <20180913124229.GD11702@lunn.ch>
References: <1536829493-10088-1-git-send-email-dongsheng.wang@hxt-semitech.com>
 <1536829493-10088-3-git-send-email-dongsheng.wang@hxt-semitech.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: timur@kernel.org, davem@davemloft.net, yu.zheng@hxt-semitech.com,
        netdev@vger.kernel.org
To: Wang Dongsheng <dongsheng.wang@hxt-semitech.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:33409 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726835AbeIMRvw (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 13 Sep 2018 13:51:52 -0400
Content-Disposition: inline
In-Reply-To: <1536829493-10088-3-git-send-email-dongsheng.wang@hxt-semitech.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Sep 13, 2018 at 05:04:53PM +0800, Wang Dongsheng wrote:
> Share the mii_bus for others MAC device because QDF2400 emac
> include MDIO, and the motherboard has more than one PHY connected
> to an MDIO bus.
> 
> Tested: QDF2400 (ACPI), buildin/insmod/rmmod
> 
> Signed-off-by: Wang Dongsheng <dongsheng.wang@hxt-semitech.com>

Hi Wang

This is a pretty big patch, and is hard to review. Could you try to
break it up into a number of smaller patches. You could for example
first refactor emacs_phy_config(), without making any functional
changes. Then add the sharing. Maybe do OF an ACPI in different
patches?

Thanks
	 Andrew