From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [net-next,RFC PATCH] Introduce TC Range classifier Date: Fri, 14 Sep 2018 11:49:32 +0200 Message-ID: <20180914094932.GK25110@nanopsycho> References: <153687160312.43503.11156697286063840163.stgit@anamhost.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, alexander.h.duyck@intel.com, jakub.kicinski@netronome.com, sridhar.samudrala@intel.com, jhs@mojatatu.com, jesse.brandeburg@intel.com, xiyou.wangcong@gmail.com To: Amritha Nambiar Return-path: Received: from mail-wm1-f65.google.com ([209.85.128.65]:51258 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726618AbeINPH2 (ORCPT ); Fri, 14 Sep 2018 11:07:28 -0400 Received: by mail-wm1-f65.google.com with SMTP id y2-v6so1322485wma.1 for ; Fri, 14 Sep 2018 02:53:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <153687160312.43503.11156697286063840163.stgit@anamhost.jf.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Sep 13, 2018 at 10:52:01PM CEST, amritha.nambiar@intel.com wrote: >This patch introduces a TC range classifier to support filtering based >on ranges. Only port-range filters are supported currently. This can >be combined with flower classifier to support filters that are a >combination of port-ranges and other parameters based on existing >fields supported by cls_flower. The 'goto chain' action can be used to >combine the flower and range filter. >The filter precedence is decided based on the 'prio' value. For example Spectrum ASIC supports mask-based and range-based matching in a single TCAM rule. No chains needed. Also, I don't really understand why is this a separate cls. I believe that this functionality should be put as an extension of existing cls_flower.