From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/2] net/sched: act_police: lockless data path Date: Sun, 16 Sep 2018 15:32:35 -0700 (PDT) Message-ID: <20180916.153235.727246482801051262.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org To: dcaratti@redhat.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:35844 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728357AbeIQD5F (ORCPT ); Sun, 16 Sep 2018 23:57:05 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Davide Caratti Date: Thu, 13 Sep 2018 19:29:11 +0200 > the data path of 'police' action can be faster if we avoid using spinlocks: > - patch 1 converts act_police to use per-cpu counters > - patch 2 lets act_police use RCU to access its configuration data. > > test procedure (using pktgen from https://github.com/netoptimizer): > # ip link add name eth1 type dummy > # ip link set dev eth1 up > # tc qdisc add dev eth1 clsact > # tc filter add dev eth1 egress matchall action police \ > > rate 2gbit burst 100k conform-exceed pass/pass index 100 > # for c in 1 2 4; do > > ./pktgen_bench_xmit_mode_queue_xmit.sh -v -s 64 -t $c -n 5000000 -i eth1 > > done > > test results (avg. pps/thread): > > $c | before patch | after patch | improvement > ----+--------------+--------------+------------- > 1 | 3518448 | 3591240 | irrelevant > 2 | 3070065 | 3383393 | 10% > 4 | 1540969 | 3238385 | 110% Series applied.