From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] veth: Orphan skb before GRO Date: Sun, 16 Sep 2018 15:34:42 -0700 (PDT) Message-ID: <20180916.153442.1718478066432353483.davem@davemloft.net> References: <1536899624-2438-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, pabeni@redhat.com, eric.dumazet@gmail.com To: makita.toshiaki@lab.ntt.co.jp Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:35884 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728190AbeIQD7M (ORCPT ); Sun, 16 Sep 2018 23:59:12 -0400 In-Reply-To: <1536899624-2438-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> Sender: netdev-owner@vger.kernel.org List-ID: From: Toshiaki Makita Date: Fri, 14 Sep 2018 13:33:44 +0900 > GRO expects skbs not to be owned by sockets, but when XDP is enabled veth > passed skbs owned by sockets. It caused corrupted sk_wmem_alloc. > > Paolo Abeni reported the following splat: ... > In order to avoid this, orphan the skb before entering GRO. > > Fixes: 948d4f214fde ("veth: Add driver XDP") > Reported-by: Paolo Abeni > Signed-off-by: Toshiaki Makita Applied, thanks.