From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: kvm@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
virtualization@lists.linux-foundation.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-mtd@lists.infradead.org, Peter Huewe <peterhuewe@gmx.de>,
linux1394-devel@lists.sourceforge.net,
devel@driverdev.osuosl.org, Jason Gunthorpe <jgg@ziepe.ca>,
Marek Vasut <marek.vasut@gmail.com>,
linux-input@vger.kernel.org,
Tomas Winkler <tomas.winkler@intel.com>,
Jiri Kosina <jikos@kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
viro@zeniv.linux.org.uk,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Artem Bityutskiy <dedekind1@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Subject: Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg
Date: Sun, 16 Sep 2018 22:07:24 +0300 [thread overview]
Message-ID: <20180916190724.GA7473@linux.intel.com> (raw)
In-Reply-To: <20180912150142.157913-2-arnd@arndb.de>
On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote:
> diff --git a/drivers/char/tpm/tpm_vtpm_proxy.c b/drivers/char/tpm/tpm_vtpm_proxy.c
> index 87a0ce47f201..a170f5ca7416 100644
> --- a/drivers/char/tpm/tpm_vtpm_proxy.c
> +++ b/drivers/char/tpm/tpm_vtpm_proxy.c
> @@ -678,20 +678,10 @@ static long vtpmx_fops_ioctl(struct file *f, unsigned int ioctl,
> }
> }
>
> -#ifdef CONFIG_COMPAT
> -static long vtpmx_fops_compat_ioctl(struct file *f, unsigned int ioctl,
> - unsigned long arg)
> -{
> - return vtpmx_fops_ioctl(f, ioctl, (unsigned long)compat_ptr(arg));
> -}
> -#endif
> -
> static const struct file_operations vtpmx_fops = {
> .owner = THIS_MODULE,
> .unlocked_ioctl = vtpmx_fops_ioctl,
> -#ifdef CONFIG_COMPAT
> - .compat_ioctl = vtpmx_fops_compat_ioctl,
> -#endif
> + .compat_ioctl = generic_compat_ioctl_ptrarg,
> .llseek = noop_llseek,
> };
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2018-09-16 19:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180912150142.157913-1-arnd@arndb.de>
2018-09-12 15:01 ` [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg Arnd Bergmann
2018-09-12 15:33 ` Jason Gunthorpe
2018-09-12 16:20 ` Arnd Bergmann
2018-09-12 18:13 ` Greg Kroah-Hartman
2018-09-16 19:07 ` Jarkko Sakkinen [this message]
[not found] ` <20180912150142.157913-1-arnd-r2nGTMty4D4@public.gmane.org>
2018-09-12 15:08 ` [PATCH v2 05/17] compat_ioctl: move more " Arnd Bergmann
2018-09-12 15:56 ` Jason Gunthorpe
2018-09-12 16:01 ` Mauro Carvalho Chehab
2018-09-14 20:35 ` Darren Hart
2018-09-14 20:57 ` Al Viro
2018-09-18 17:51 ` Darren Hart
2018-09-18 17:59 ` Jason Gunthorpe
[not found] ` <20180918175952.GJ11367-uk2M96/98Pc@public.gmane.org>
2018-09-24 20:18 ` Arnd Bergmann
2018-09-24 20:35 ` Jason Gunthorpe
[not found] ` <20180924203505.GC6008-uk2M96/98Pc@public.gmane.org>
2018-09-24 21:17 ` Arnd Bergmann
[not found] ` <20180912151134.436719-1-arnd-r2nGTMty4D4@public.gmane.org>
2018-09-12 15:58 ` Daniel Vetter
2018-09-12 18:13 ` Greg Kroah-Hartman
2018-09-14 14:23 ` David Sterba
2018-09-17 9:33 ` Jonathan Cameron
2018-10-06 7:05 ` Bjorn Andersson
[not found] ` <20180912151422.571531-1-arnd@arndb.de>
2018-09-12 15:13 ` [PATCH v2 11/17] compat_ioctl: remove isdn ioctl translation Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180916190724.GA7473@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=benjamin.tissoires@redhat.com \
--cc=dedekind1@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jgg@ziepe.ca \
--cc=jikos@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=marek.vasut@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stefanr@s5r6.in-berlin.de \
--cc=sudipm.mukherjee@gmail.com \
--cc=tomas.winkler@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).