From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] bnxt_en: Fix VF mac address regression. Date: Mon, 17 Sep 2018 07:58:56 -0700 (PDT) Message-ID: <20180917.075856.398619959844920361.davem@davemloft.net> References: <1536954089-6061-1-git-send-email-michael.chan@broadcom.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, seth.forshee@canonical.com, loseweigh@gmail.com To: michael.chan@broadcom.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:45710 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728374AbeIQU0i (ORCPT ); Mon, 17 Sep 2018 16:26:38 -0400 In-Reply-To: <1536954089-6061-1-git-send-email-michael.chan@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Michael Chan Date: Fri, 14 Sep 2018 15:41:29 -0400 > The recent commit to always forward the VF MAC address to the PF for > approval may not work if the PF driver or the firmware is older. This > will cause the VF driver to fail during probe: > > bnxt_en 0000:00:03.0 (unnamed net_device) (uninitialized): hwrm req_type 0xf seq id 0x5 error 0xffff > bnxt_en 0000:00:03.0 (unnamed net_device) (uninitialized): VF MAC address 00:00:17:02:05:d0 not approved by the PF > bnxt_en 0000:00:03.0: Unable to initialize mac address. > bnxt_en: probe of 0000:00:03.0 failed with error -99 > > We fix it by treating the error as fatal only if the VF MAC address is > locally generated by the VF. > > Fixes: 707e7e966026 ("bnxt_en: Always forward VF MAC address to the PF.") > Reported-by: Seth Forshee > Reported-by: Siwei Liu > Signed-off-by: Michael Chan > --- > Please queue this for stable as well. Thanks. Applied and queued up for -stable.