* [PATCH net-next] net: hns: make function hns_gmac_wait_fifo_clean() static
@ 2018-09-15 1:42 Wei Yongjun
2018-09-17 15:07 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-09-15 1:42 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta, Peng Li, Matthias Brugger
Cc: Wei Yongjun, netdev, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c:322:5: warning:
symbol 'hns_gmac_wait_fifo_clean' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c
index 09e4061..aaf72c0 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c
@@ -319,7 +319,7 @@ static void hns_gmac_set_promisc(void *mac_drv, u8 en)
hns_gmac_set_uc_match(mac_drv, en);
}
-int hns_gmac_wait_fifo_clean(void *mac_drv)
+static int hns_gmac_wait_fifo_clean(void *mac_drv)
{
struct mac_driver *drv = (struct mac_driver *)mac_drv;
int wait_cnt;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: hns: make function hns_gmac_wait_fifo_clean() static
2018-09-15 1:42 [PATCH net-next] net: hns: make function hns_gmac_wait_fifo_clean() static Wei Yongjun
@ 2018-09-17 15:07 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-09-17 15:07 UTC (permalink / raw)
To: weiyongjun1
Cc: yisen.zhuang, salil.mehta, lipeng321, matthias.bgg, netdev,
kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Sat, 15 Sep 2018 01:42:09 +0000
> Fixes the following sparse warning:
>
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c:322:5: warning:
> symbol 'hns_gmac_wait_fifo_clean' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-17 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-15 1:42 [PATCH net-next] net: hns: make function hns_gmac_wait_fifo_clean() static Wei Yongjun
2018-09-17 15:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).