From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] net: fix return type of ndo_start_xmit
 function
Date: Mon, 17 Sep 2018 08:09:45 -0700 (PDT)
Message-ID: <20180917.080945.1667529660601929619.davem@davemloft.net>
References: <20180915081906.23816-1-yuehaibing@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        dev@openvswitch.org
To: yuehaibing@huawei.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20180915081906.23816-1-yuehaibing@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org


Please don't do this.

The hard part of fixing this is not what you are doing, changing the
return type.

The hard part is fixing each and every function to actually return
values which are members of the netdev_tx_t enumeration.

Please fix each and every function properly.

Thank you.