From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: caif: remove redundant null check on frontpkt Date: Mon, 17 Sep 2018 18:50:58 -0700 (PDT) Message-ID: <20180917.185058.178327866298767220.davem@davemloft.net> References: <20180914171916.21298-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: dmitry.tarnyagin@lockless.no, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org To: colin.king@canonical.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:53914 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726493AbeIRHVF (ORCPT ); Tue, 18 Sep 2018 03:21:05 -0400 In-Reply-To: <20180914171916.21298-1-colin.king@canonical.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Colin King Date: Fri, 14 Sep 2018 18:19:16 +0100 > From: Colin Ian King > > It is impossible for frontpkt to be null at the point of the null > check because it has been assigned from rearpkt and there is no > way realpkt can be null at the point of the assignment because > of the sanity checking and exit paths taken previously. Remove > the redundant null check. > > Detected by CoverityScan, CID#114434 ("Logically dead code") > > Signed-off-by: Colin Ian King Appied to net-next with typo fixed. Thanks.