From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2] libnetlink: fix leak and using unused memory
 on error
Date: Mon, 17 Sep 2018 08:37:07 -0700
Message-ID: <20180917083707.5c0e3ff0@xeon-e3>
References: <20180913193338.20233-1-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: Mahesh Bandewar <mahesh@bandewar.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f193.google.com ([209.85.214.193]:35607 "EHLO
        mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728554AbeIQVFH (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 17 Sep 2018 17:05:07 -0400
Received: by mail-pl1-f193.google.com with SMTP id g2-v6so7604266plo.2
        for <netdev@vger.kernel.org>; Mon, 17 Sep 2018 08:37:16 -0700 (PDT)
In-Reply-To: <20180913193338.20233-1-stephen@networkplumber.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 13 Sep 2018 12:33:38 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> If an error happens in multi-segment message (tc only)
> then report the error and stop processing further responses.
> This also fixes refering to the buffer after free.
> 
> The sequence check is not necessary here because the
> response message has already been validated to be in
> the window of the sequence number of the iov.
> 
> Reported-by: Mahesh Bandewar <mahesh@bandewar.net>
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Bad habit of working on two projects as once.