From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] net: phy: phylink: fix SFP interface autodetection Date: Mon, 17 Sep 2018 16:12:30 +0100 Message-ID: <20180917151230.GF30658@n2100.armlinux.org.uk> References: <18cf7eb4b6253f922d3dc6cb70eb7d050c32c35e.1537193997.git.baruch@tkos.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, Antoine Tenart , Gregory CLEMENT To: Baruch Siach Return-path: Received: from pandora.armlinux.org.uk ([78.32.30.218]:46170 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728573AbeIQUk1 (ORCPT ); Mon, 17 Sep 2018 16:40:27 -0400 Content-Disposition: inline In-Reply-To: <18cf7eb4b6253f922d3dc6cb70eb7d050c32c35e.1537193997.git.baruch@tkos.co.il> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Sep 17, 2018 at 05:19:57PM +0300, Baruch Siach wrote: > When the switching to the SFP detected link mode update the main > link_interface field as well. Otherwise, the link fails to come up when > the configured 'phy-mode' defers from the SFP detected mode. > > This fixes 1GB SFP module link up on eth3 of the Macchiatobin board that > is configured in the DT to "2500base-x" phy-mode. link_interface isn't supposed to track the SFP link mode. In any case, this is only used when a PHY is attached. For a PHY on a SFP, phylink_connect_phy() should be using link_config.interface and not link_interface there. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up