From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio Subject: Re: [PATCH net] selftests: pmtu: properly redirect stderr to /dev/null Date: Mon, 17 Sep 2018 15:45:22 +0200 Message-ID: <20180917154522.2ee029a4@epycfail> References: <132b14cab49cd959d9cf6e6607b01c383db2d984.1537190905.git.sd@queasysnail.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Sabrina Dubroca Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51512 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728085AbeIQTMx (ORCPT ); Mon, 17 Sep 2018 15:12:53 -0400 In-Reply-To: <132b14cab49cd959d9cf6e6607b01c383db2d984.1537190905.git.sd@queasysnail.net> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 17 Sep 2018 15:30:06 +0200 Sabrina Dubroca wrote: > The cleanup function uses "$CMD 2 > /dev/null", which doesn't actually > send stderr to /dev/null, so when the netns doesn't exist, the error > message is shown. Use "2> /dev/null" instead, so that those messages > disappear, as was intended. Oops, thanks for catching this. > Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test") > Signed-off-by: Sabrina Dubroca Acked-by: Stefano Brivio -- Stefano