* [PATCH net] selftests: pmtu: properly redirect stderr to /dev/null
@ 2018-09-17 13:30 Sabrina Dubroca
2018-09-17 13:45 ` Stefano Brivio
2018-09-19 2:54 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Sabrina Dubroca @ 2018-09-17 13:30 UTC (permalink / raw)
To: netdev; +Cc: Sabrina Dubroca, Stefano Brivio
The cleanup function uses "$CMD 2 > /dev/null", which doesn't actually
send stderr to /dev/null, so when the netns doesn't exist, the error
message is shown. Use "2> /dev/null" instead, so that those messages
disappear, as was intended.
Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
---
tools/testing/selftests/net/pmtu.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
index 32a194e3e07a..0ab9423d009f 100755
--- a/tools/testing/selftests/net/pmtu.sh
+++ b/tools/testing/selftests/net/pmtu.sh
@@ -178,8 +178,8 @@ setup() {
cleanup() {
[ ${cleanup_done} -eq 1 ] && return
- ip netns del ${NS_A} 2 > /dev/null
- ip netns del ${NS_B} 2 > /dev/null
+ ip netns del ${NS_A} 2> /dev/null
+ ip netns del ${NS_B} 2> /dev/null
cleanup_done=1
}
--
2.19.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] selftests: pmtu: properly redirect stderr to /dev/null
2018-09-17 13:30 [PATCH net] selftests: pmtu: properly redirect stderr to /dev/null Sabrina Dubroca
@ 2018-09-17 13:45 ` Stefano Brivio
2018-09-19 2:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Brivio @ 2018-09-17 13:45 UTC (permalink / raw)
To: Sabrina Dubroca; +Cc: netdev
On Mon, 17 Sep 2018 15:30:06 +0200
Sabrina Dubroca <sd@queasysnail.net> wrote:
> The cleanup function uses "$CMD 2 > /dev/null", which doesn't actually
> send stderr to /dev/null, so when the netns doesn't exist, the error
> message is shown. Use "2> /dev/null" instead, so that those messages
> disappear, as was intended.
Oops, thanks for catching this.
> Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Acked-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] selftests: pmtu: properly redirect stderr to /dev/null
2018-09-17 13:30 [PATCH net] selftests: pmtu: properly redirect stderr to /dev/null Sabrina Dubroca
2018-09-17 13:45 ` Stefano Brivio
@ 2018-09-19 2:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-09-19 2:54 UTC (permalink / raw)
To: sd; +Cc: netdev, sbrivio
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Mon, 17 Sep 2018 15:30:06 +0200
> The cleanup function uses "$CMD 2 > /dev/null", which doesn't actually
> send stderr to /dev/null, so when the netns doesn't exist, the error
> message is shown. Use "2> /dev/null" instead, so that those messages
> disappear, as was intended.
>
> Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-19 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-17 13:30 [PATCH net] selftests: pmtu: properly redirect stderr to /dev/null Sabrina Dubroca
2018-09-17 13:45 ` Stefano Brivio
2018-09-19 2:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).