From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Cc: Tushar Dave <tushar.n.dave@oracle.com>,
ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net,
santosh.shilimkar@oracle.com, jakub.kicinski@netronome.com,
quentin.monnet@netronome.com, jiong.wang@netronome.com,
sandipan@linux.vnet.ibm.com, john.fastabend@gmail.com,
kafai@fb.com, rdna@fb.com, yhs@fb.com, netdev@vger.kernel.org,
rds-devel@oss.oracle.com
Subject: Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER
Date: Mon, 17 Sep 2018 16:15:16 -0700 [thread overview]
Message-ID: <20180917231513.mevvgup4y4qnrb2k@ast-mbp> (raw)
In-Reply-To: <20180913101013.GA1039@oracle.com>
On Thu, Sep 13, 2018 at 06:10:13AM -0400, Sowmini Varadhan wrote:
> On (09/12/18 19:07), Alexei Starovoitov wrote:
> >
> > I didn't know that. The way I understand your statement that
> > this new program type, new sg logic, and all the complexity
> > are only applicable to RDMA capable hw and RDS.
>
> I dont know if you have been following the RFC series at all
> (and DanielB/JohnF feedback to it) but that is not what the patch
> set is about.
>
> To repeat a summary of the original problem statement:
>
> RDS (hardly a "niche" driver, let's please not get carried away
> with strong assertions based on incomplete understanding),
> is an example of a driver that happens to pass up packets
> as both scatterlist and sk_buffs to the ULPs.
>
> The scatterlist comes from IB, the sk_buffs come from the ethernet
> drivers. At the moment, the only way to build firewalls for
> this is to convert scatterlist to skb and use either netfilter
> or eBPF on the skb. What Tushar is adding is support to use eBPF
> on the scatterlist itself, so that you dont have to do this
> inefficient scatterlist->skb conversion.
if the goal is to add firewall ability to RDS then the patch set
is going in the wrong direction.
New bpf prog type and attaching to sockets isn't going to be
helpful in building firewalls.
Also there was a mention of some form of 'redirect' for some
future use? That doesn't fit the firewall goal as well.
I think it would be the best to start from scratch and discuss
the bigger goal first.
May be the right answer is to teach rds to behave like the rest of protocols.
Then all existing tooling and features will 'just work' ?
next prev parent reply other threads:[~2018-09-18 4:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 19:37 [PATCH net-next 0/5] eBPF and struct scatterlist Tushar Dave
2018-09-11 19:38 ` [PATCH net-next 1/5] bpf: use __GFP_COMP while allocating page Tushar Dave
2018-09-12 16:21 ` Tushar Dave
2018-09-12 16:51 ` John Fastabend
2018-09-12 20:15 ` Tushar Dave
2018-09-11 19:38 ` [PATCH net-next 2/5] eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER Tushar Dave
2018-09-12 3:57 ` Alexei Starovoitov
2018-09-12 19:25 ` Tushar Dave
2018-09-11 19:38 ` [PATCH net-next 3/5] ebpf: Add sg_filter_run() Tushar Dave
2018-09-12 3:58 ` Alexei Starovoitov
2018-09-12 19:27 ` Tushar Dave
2018-09-11 19:38 ` [PATCH net-next 4/5] rds: invoke socket sg filter attached to rds socket Tushar Dave
2018-09-11 21:06 ` santosh.shilimkar
2018-09-11 19:38 ` [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER Tushar Dave
2018-09-12 4:00 ` Alexei Starovoitov
2018-09-12 19:32 ` Tushar Dave
2018-09-13 0:59 ` Sowmini Varadhan
2018-09-13 2:07 ` Alexei Starovoitov
2018-09-13 10:10 ` Sowmini Varadhan
2018-09-17 23:15 ` Alexei Starovoitov [this message]
2018-09-17 23:23 ` Sowmini Varadhan
2018-09-17 23:26 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917231513.mevvgup4y4qnrb2k@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiong.wang@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@netronome.com \
--cc=rdna@fb.com \
--cc=rds-devel@oss.oracle.com \
--cc=sandipan@linux.vnet.ibm.com \
--cc=santosh.shilimkar@oracle.com \
--cc=sowmini.varadhan@oracle.com \
--cc=tushar.n.dave@oracle.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox