From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2 03/10] net: sched: extend Qdisc with rcu Date: Tue, 18 Sep 2018 19:45:34 -0700 (PDT) Message-ID: <20180918.194534.347028964384680999.davem@redhat.com> References: <1537168660-24032-1-git-send-email-vladbu@mellanox.com> <1537168660-24032-4-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, stephen@networkplumber.org, ktkhai@virtuozzo.com, nicolas.dichtel@6wind.com, gregkh@linuxfoundation.org, mark.rutland@arm.com, leon@kernel.org, paulmck@linux.vnet.ibm.com, fw@strlen.de, dsahern@gmail.com, christian@brauner.io, lucien.xin@gmail.com, jakub.kicinski@netronome.com, jbenc@redhat.com To: vladbu@mellanox.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47942 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbeISIVV (ORCPT ); Wed, 19 Sep 2018 04:21:21 -0400 In-Reply-To: <1537168660-24032-4-git-send-email-vladbu@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Vlad Buslov Date: Mon, 17 Sep 2018 10:17:33 +0300 > +struct Qdisc *qdisc_lookup_rcu(struct net_device *dev, u32 handle) > +{ > + struct Qdisc *q; > + struct netdev_queue *nq; Reverse christmas tree for the local variables, please.