From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] selftests: pmtu: properly redirect stderr to /dev/null Date: Tue, 18 Sep 2018 19:54:14 -0700 (PDT) Message-ID: <20180918.195414.781656855371547369.davem@redhat.com> References: <132b14cab49cd959d9cf6e6607b01c383db2d984.1537190905.git.sd@queasysnail.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sbrivio@redhat.com To: sd@queasysnail.net Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46098 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbeISIaA (ORCPT ); Wed, 19 Sep 2018 04:30:00 -0400 In-Reply-To: <132b14cab49cd959d9cf6e6607b01c383db2d984.1537190905.git.sd@queasysnail.net> Sender: netdev-owner@vger.kernel.org List-ID: From: Sabrina Dubroca Date: Mon, 17 Sep 2018 15:30:06 +0200 > The cleanup function uses "$CMD 2 > /dev/null", which doesn't actually > send stderr to /dev/null, so when the netns doesn't exist, the error > message is shown. Use "2> /dev/null" instead, so that those messages > disappear, as was intended. > > Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test") > Signed-off-by: Sabrina Dubroca Applied.