From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: mvpp2: fix a txq_done race condition Date: Tue, 18 Sep 2018 20:14:01 -0700 (PDT) Message-ID: <20180918.201401.955097214067299890.davem@redhat.com> References: <20180918145847.11318-1-antoine.tenart@bootlin.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com To: antoine.tenart@bootlin.com Return-path: In-Reply-To: <20180918145847.11318-1-antoine.tenart@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Antoine Tenart Date: Tue, 18 Sep 2018 16:58:47 +0200 > When no Tx IRQ is available, the txq_done() routine (called from > tx_done()) shouldn't be called from the polling function, as in such > case it is already called in the Tx path thanks to an hrtimer. This > mostly occurred when using PPv2.1, as the engine then do not have Tx > IRQs. > > Fixes: edc660fa09e2 ("net: mvpp2: replace TX coalescing interrupts with hrtimer") > Reported-by: Stefan Chulski > Signed-off-by: Antoine Tenart Applied and queued up for -stable.