From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net-next] cxgb4vf: Add ethtool private flags for changing force_link_up Date: Tue, 18 Sep 2018 11:39:14 -0700 Message-ID: <20180918113914.58811ecf@cakuba.netronome.com> References: <1537276043-20666-1-git-send-email-arjun@chelsio.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, dt@chelsio.com, nirranjan@chelsio.com, indranil@chelsio.com, Casey Leedom , Ganesh Goudar To: Arjun Vynipadath Return-path: Received: from mail-qk1-f194.google.com ([209.85.222.194]:45372 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729946AbeISANM (ORCPT ); Tue, 18 Sep 2018 20:13:12 -0400 Received: by mail-qk1-f194.google.com with SMTP id z125-v6so1564524qkb.12 for ; Tue, 18 Sep 2018 11:39:19 -0700 (PDT) In-Reply-To: <1537276043-20666-1-git-send-email-arjun@chelsio.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 18 Sep 2018 18:37:23 +0530, Arjun Vynipadath wrote: > Forcing link up of virtual interfaces even when physical link is down > causes packet drops and ping failures during bonding failover. Hence > adding a ethtool private flag to toggle force_link_up whenever required. > > Signed-off-by: Arjun Vynipadath > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar Could you describe how this mechanism relates to the existing ndo_set_vf_link_state, which you seem to not make use of: $ git grep ndo_set_vf_link_state -- drivers/net/ethernet/chelsio/ $ I understand you're configuring the setting from the VF side, but the question, as always, is: why ;)