From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [RFC PATCH bpf-next v3 1/7] bpf: rename stack trace map Date: Tue, 18 Sep 2018 16:05:52 -0700 Message-ID: <20180918230551.7rh3wytacry7i3wl@ast-mbp> References: <153724634652.7866.6354309647800281793.stgit@kernel> <153724635419.7866.6301500459081173494.stgit@kernel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, Yonghong Song To: Mauricio Vasquez B Return-path: Received: from mail-pg1-f194.google.com ([209.85.215.194]:43969 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbeISEkp (ORCPT ); Wed, 19 Sep 2018 00:40:45 -0400 Received: by mail-pg1-f194.google.com with SMTP id q19-v6so887589pgn.10 for ; Tue, 18 Sep 2018 16:05:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <153724635419.7866.6301500459081173494.stgit@kernel> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Sep 18, 2018 at 06:52:34AM +0200, Mauricio Vasquez B wrote: > In the following patches queue and stack maps (FIFO and LIFO > datastructures) will be implemented. In order to avoid confusion and > a possible name clash rename stackmap.c to stacktracemap.c and > stack_map_ops to stack_trace_map_ops > > Signed-off-by: Mauricio Vasquez B > --- > include/linux/bpf_types.h | 2 > kernel/bpf/Makefile | 2 > kernel/bpf/stackmap.c | 624 -------------------------------------------- > kernel/bpf/stacktracemap.c | 624 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 626 insertions(+), 626 deletions(-) > delete mode 100644 kernel/bpf/stackmap.c > create mode 100644 kernel/bpf/stacktracemap.c Just new file for stack/queue will be enough. I understand that unfortunate name confusion, but this is too late. It will cause all sorts of headaches in fixes that go to net/stable.