netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH net-next] nfp: provide a better warning when ring allocation fails
Date: Wed, 19 Sep 2018 23:08:11 -0700 (PDT)	[thread overview]
Message-ID: <20180919.230811.1563424826242813077.davem@davemloft.net> (raw)
In-Reply-To: <20180919214250.12214-1-jakub.kicinski@netronome.com>

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed, 19 Sep 2018 14:42:50 -0700

> NFP supports fairly enormous ring sizes (up to 256k descriptors).
> In commit 466271703867 ("nfp: use kvcalloc() to allocate SW buffer
> descriptor arrays") we have started using kvcalloc() functions to
> make sure the allocation of software state arrays doesn't hit
> the MAX_ORDER limit.  Unfortunately, we can't use virtual mappings
> for the DMA region holding HW descriptors.  In case this allocation
> fails instead of the generic (and fairly scary) warning/splat in
> the logs print a helpful message explaining what happened and
> suggesting how to fix it.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>

Applied.

      reply	other threads:[~2018-09-20 11:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 21:42 [PATCH net-next] nfp: provide a better warning when ring allocation fails Jakub Kicinski
2018-09-20  6:08 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180919.230811.1563424826242813077.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).