From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] nfp: provide a better warning when ring allocation fails Date: Wed, 19 Sep 2018 23:08:11 -0700 (PDT) Message-ID: <20180919.230811.1563424826242813077.davem@davemloft.net> References: <20180919214250.12214-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:35430 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731260AbeITLtz (ORCPT ); Thu, 20 Sep 2018 07:49:55 -0400 In-Reply-To: <20180919214250.12214-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Wed, 19 Sep 2018 14:42:50 -0700 > NFP supports fairly enormous ring sizes (up to 256k descriptors). > In commit 466271703867 ("nfp: use kvcalloc() to allocate SW buffer > descriptor arrays") we have started using kvcalloc() functions to > make sure the allocation of software state arrays doesn't hit > the MAX_ORDER limit. Unfortunately, we can't use virtual mappings > for the DMA region holding HW descriptors. In case this allocation > fails instead of the generic (and fairly scary) warning/splat in > the logs print a helpful message explaining what happened and > suggesting how to fix it. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Dirk van der Merwe Applied.