From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH net-next 1/3] net: phy: phylink: ensure the carrier is off when starting phylink Date: Wed, 19 Sep 2018 11:07:01 +0100 Message-ID: <20180919100701.GI30658@n2100.armlinux.org.uk> References: <20180919093933.24411-1-antoine.tenart@bootlin.com> <20180919093933.24411-2-antoine.tenart@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com To: Antoine Tenart Return-path: Received: from pandora.armlinux.org.uk ([78.32.30.218]:46578 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727605AbeISPof (ORCPT ); Wed, 19 Sep 2018 11:44:35 -0400 Content-Disposition: inline In-Reply-To: <20180919093933.24411-2-antoine.tenart@bootlin.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Sep 19, 2018 at 11:39:31AM +0200, Antoine Tenart wrote: > Phylink made an assumption about the carrier state being down when > calling phylink_start(). If this assumption isn't satisfied, the > internal phylink state could misbehave and a net device could end up not > being functional. > > This patch fixes this by explicitly calling netif_carrier_off() in > phylink_start(). > > Signed-off-by: Antoine Tenart Acked-by: Russell King Thanks. > --- > drivers/net/phy/phylink.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c > index 3ba5cf2a8a5f..1d01e0c625a5 100644 > --- a/drivers/net/phy/phylink.c > +++ b/drivers/net/phy/phylink.c > @@ -901,6 +901,9 @@ void phylink_start(struct phylink *pl) > phylink_an_mode_str(pl->link_an_mode), > phy_modes(pl->link_config.interface)); > > + /* Always set the carrier off */ > + netif_carrier_off(pl->netdev); > + > /* Apply the link configuration to the MAC when starting. This allows > * a fixed-link to start with the correct parameters, and also > * ensures that we set the appropriate advertisement for Serdes links. > -- > 2.17.1 > -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up