From: Petr Vorel <petr.vorel@gmail.com>
To: netdev@vger.kernel.org
Cc: Petr Vorel <petr.vorel@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Phil Sutter <phil@nwl.cc>, Luca Boccassi <bluca@debian.org>
Subject: [PATCH iproute2 v2 1/3] testsuite: Fix missing generate_nlmsg
Date: Thu, 20 Sep 2018 01:36:22 +0200 [thread overview]
Message-ID: <20180919233624.18494-2-petr.vorel@gmail.com> (raw)
In-Reply-To: <20180919233624.18494-1-petr.vorel@gmail.com>
Commit ad23e152 caused generate_nlmsg to be always missing:
$ make alltests
make: ./tools/generate_nlmsg: Command not found
Create testclean: to remove only results directory.
Fixes: ad23e152 testsuite: remove all temp files and implement make clean
Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
testsuite/Makefile | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/testsuite/Makefile b/testsuite/Makefile
index d1ac997d..a31d4531 100644
--- a/testsuite/Makefile
+++ b/testsuite/Makefile
@@ -30,7 +30,6 @@ configure:
compile: configure
echo "Entering iproute2" && cd iproute2 && $(MAKE) && cd ..;
- $(MAKE) -C tools
listtests:
@for t in $(TESTS); do \
@@ -39,9 +38,11 @@ listtests:
alltests: $(TESTS)
-clean:
+testclean:
@echo "Removing $(RESULTS_DIR) dir ..."
@rm -rf $(RESULTS_DIR)
+
+clean: testclean
@rm -f iproute2/iproute2-this
@rm -f tests/ip/link/dev_wo_vf_rate.nl
$(MAKE) -C tools clean
@@ -49,18 +50,18 @@ clean:
distclean: clean
echo "Entering iproute2" && cd iproute2 && $(MAKE) distclean && cd ..;
-$(TESTS): clean
+$(TESTS): testclean
ifeq (,$(HAVE_UNSHARED_UTIL))
$(error Please install util-linux tools to run tests in separated network namespace)
endif
@./tools/generate_nlmsg
@mkdir -p $(RESULTS_DIR)
-
+
@for d in $(TESTS_DIR); do \
mkdir -p $(RESULTS_DIR)/$$d; \
done
-
+
@if [ "$(KCPATH)" = "/proc/config.gz" ]; then \
gunzip -c $(KCPATH) >$(KENVFN); \
elif [ "$(KCPATH)" != "" ]; then \
--
2.19.0.rc2
next prev parent reply other threads:[~2018-09-20 5:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 23:36 [PATCH iproute2 v2 0/3] testsuite: make alltests fixes Petr Vorel
2018-09-19 23:36 ` Petr Vorel [this message]
2018-09-19 23:36 ` [PATCH iproute2 v2 2/3] testsuite: Generate generate_nlmsg when needed Petr Vorel
2018-09-19 23:36 ` [PATCH iproute2 v2 3/3] testsuite: Warn about empty $(IPVERS) Petr Vorel
2018-09-20 8:02 ` [PATCH iproute2 v2 0/3] testsuite: make alltests fixes Phil Sutter
2018-09-20 10:02 ` Luca Boccassi
2018-09-21 16:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919233624.18494-2-petr.vorel@gmail.com \
--to=petr.vorel@gmail.com \
--cc=bluca@debian.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).